----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43411 -----------------------------------------------------------
I don't get the "dependency of a dependency" thing, surely once KI18N is found, it's found, there's no need to find it again. But whatever - this is temporary anyway, cmake-3 will get rid of the need for that. tier1/kcoreaddons/src/lib/CMakeLists.txt <http://git.reviewboard.kde.org/r/113723/#comment31261> add a comment to each installed private header, otherwise the next generation will really wonder why they are installed. e.g. # for KIO::CopyJob tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h <http://git.reviewboard.kde.org/r/113723/#comment31262> Err.... why did you remove the inheritance from KJobPrivate, which is in the same library as KCompositeJobPrivate?? If this is from "my advice", it's a misunderstanding. My advice was to cut the inheritance between kio and kcoreaddons. Not within kcoreaddons. - David Faure On Nov. 11, 2013, 3:23 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113723/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 3:23 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > As you will see, this splitting was a bit harder than others: > - KIO was using a couple of private headers from kjobwidgets, which now they > will be installed. > - The xslt_kde target was being used from KDocTools without having it > exported. Now it will be properly exported. > - Also defines all dependencies so it can be compiled independently, > modularization is done as well. > > > Diffs > ----- > > staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc > staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6 > staging/kio/CMakeLists.txt 6c7297e > cmake/modules/FindGSSAPI.cmake > cmake/modules/CMakeLists.txt 07f7eac > staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt 2630f01 > staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c > staging/kio/src/widgets/CMakeLists.txt d90386d > staging/kio/src/widgets/kopenwithdialog.cpp cb4fc0f > staging/kio/tests/CMakeLists.txt 6cee291 > superbuild/CMakeLists.txt 53f5952 > tier1/kcoreaddons/src/lib/CMakeLists.txt 4e6e206 > tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h 20baf7c > tier2/kdoctools/CMakeLists.txt c2256ff > tier2/kdoctools/KDocToolsConfig.cmake d501dc8 > tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION > tier2/kdoctools/src/CMakeLists.txt 3940e98 > tier3/kded/KDEDConfig.cmake.in 32f8d56 > > Diff: http://git.reviewboard.kde.org/r/113723/diff/ > > > Testing > ------- > > Builds, Installs, tests still pass; both modularized and monolithic kdelibs. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
