----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43603 -----------------------------------------------------------
This review has been submitted with commit fc714169fb713bb74246c0be6ec5a25d99245bc1 by Aleix Pol to branch frameworks. - Commit Hook On Nov. 12, 2013, 6:46 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113821/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 6:46 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kdelibs > > > Description > ------- > > This makes sure that KWidgetsAddons doesn't expose any private dependencies. > > The only user of that file was KCMultiDialogPrivate. This patch refactors the > code so that it's used separately. > > > Diffs > ----- > > tier1/kwidgetsaddons/src/CMakeLists.txt 76679a4 > tier4/kcmutils/src/kcmultidialog.h 3518736 > tier4/kcmutils/src/kcmultidialog.cpp 9d2ccbb > tier4/kcmutils/src/kcmultidialog_p.h ad5dd98 > > Diff: http://git.reviewboard.kde.org/r/113821/diff/ > > > Testing > ------- > > Everything builds, couldn't test since I didn't see any test. > > Tests still pass though. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
