----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113935/#review43942 -----------------------------------------------------------
tier1/kguiaddons/cmake/FindOpenEXR.cmake <http://git.reviewboard.kde.org/r/113935/#comment31558> Instead of this, please use what cmake --help-module FindPackageHandleStandardArgs calls mode 2. - Stephen Kelly On Nov. 19, 2013, 2:17 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113935/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2013, 2:17 p.m.) > > > Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. > > > Repository: kdelibs > > > Description > ------- > > Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake > > Only kguiaddons uses it for now; it can be moved to ECM later if there > is another user. > > > This replaces https://git.reviewboard.kde.org/r/113834/ and > https://git.reviewboard.kde.org/r/113828/ > > > Diffs > ----- > > tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION > tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt > 6637a16711d21c2a180914ad2530e3ac85b14a22 > tier4/kde4support/cmake/modules/CMakeLists.txt > 2911e70f3dd253ab552bfd228a25b3ae38452218 > tier4/kde4support/cmake/modules/FindOpenEXR.cmake > 93b05dd999c12605973c1a0a2020a72aece88b65 > tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a > > Diff: http://git.reviewboard.kde.org/r/113935/diff/ > > > Testing > ------- > > OpenEXR is found, both on an existing build of kdelibs-frameworks and on a > clean run of CMake. Still builds and links properly. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
