> On Nov. 21, 2013, 12:42 p.m., Àlex Fiestas wrote: > > KIcon can get rid of the dependency since now QIcon will use the > > QPlatformTheme to obtain the engine, meaning that all QIcon will have our > > KIconEngine already. > > > > for the case of the PlatformTheme, we do need that header.
Meh, we looked at this more closely and we need KIconLoader for overlay... so we can't remove the usage of it in KIcon. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44106 ----------------------------------------------------------- On Nov. 21, 2013, 12:29 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113996/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 12:29 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > There are 2 headers to install: > - kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it > should be installed > - kiconengine_p.h: I have no idea, but it's still needed. (note it's also > needed by kicon.cpp in kde4support). > > > Diffs > ----- > > tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf > tier3/kiconthemes/src/CMakeLists.txt 4b3c978 > > Diff: http://git.reviewboard.kde.org/r/113996/diff/ > > > Testing > ------- > > FrameworksIntegration builds modularized, monolithic kdelibs still build as > well. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
