> On Nov. 25, 2013, 3:49 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. > > Bhushan Shah wrote: > No I am not able to run cmake, it fails.. > > Alex Merry wrote: > Yeah, this is apparently a known bug with current versions of CMake > (pre-3.0.0). But we have to support 2.8.12, so we need to include the > private dependencies of the things we link to. > > Bhushan Shah wrote: > @Alex Merry so ship it?
Although... KGuiAddons is a *public* dependency of KConfigWidgets, so the KConfigWidgetsConfig.cmake file should include KGuiAddons. So I'm surprised this is needed. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/#review44430 ----------------------------------------------------------- On Nov. 25, 2013, 3:32 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114111/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 3:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > summary ^ > > > it complains about KGuiAddons in cmake. it fixes this.. > > > Diffs > ----- > > tier3/kiconthemes/CMakeLists.txt d1191d1 > > Diff: http://git.reviewboard.kde.org/r/114111/diff/ > > > Testing > ------- > > compiles, links, installs. > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
