> On Nov. 24, 2013, 10:58 a.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/kaboutdata.cpp, line 957 > > <http://git.reviewboard.kde.org/r/114038/diff/1/?file=219248#file219248line957> > > > > (LOL, most likely someone forgot to call addAuthor, but OK :) > > > > > > Wrong usage of tr() (this will use QCoreApplication as context). Use > > tr() (might need Q_DECLARE_TR_FUNCTIONS in the header, since this isn't a > > QObject), or use translate() with a context, like in the example program in > > this patch.
I used the same we used to have in KCmdLineArgs. I agree it looks a bit aggressive though :). As if there was any kind of anonymity going on... I'll fix the ::tr usage. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/#review44296 ----------------------------------------------------------- On Nov. 22, 2013, 6:07 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114038/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 6:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > There was a functionality regression from KDE4 where every application would > get an --authors and a --license argument automatically. > > This patch makes it possible to let KAboutData configure QCommandLineParser > to add the missing arguments and react if those are required. > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/kaboutdata.h f9dee8e > tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 > tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 > tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad > > Diff: http://git.reviewboard.kde.org/r/114038/diff/ > > > Testing > ------- > > Made kbuildsycoca5 use it and made sure it works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
