----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/#review45465 -----------------------------------------------------------
tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in <http://git.reviewboard.kde.org/r/114356/#comment32420> Shouldn't that file be called KGlobalAccelConfig.cmake.in? We're not prefixing the rest of modules with KF5, right? - Aleix Pol Gonzalez On Dec. 10, 2013, 6:41 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114356/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 6:41 a.m.) > > > Review request for KDE Frameworks and Martin Klapetek. > > > Repository: kdelibs > > > Description > ------- > > New framework needs DBus, Widgets and (optionally) X11Extras as dependencies. > > @MartinK: how should we organize the renaming? I'm still using the old naming > scheme. So should I adjust or should we use your scripts after pulling this > one in? > > > Diffs > ----- > > tier1/CMakeLists.txt 450ca57 > tier1/kglobalaccel/CMakeLists.txt PRE-CREATION > tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in PRE-CREATION > tier1/kglobalaccel/autotests/CMakeLists.txt PRE-CREATION > tier1/kglobalaccel/autotests/kglobalshortcuttest.h PRE-CREATION > tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp PRE-CREATION > tier1/kglobalaccel/src/CMakeLists.txt PRE-CREATION > tier1/kglobalaccel/src/config-kglobalaccel.h.cmake PRE-CREATION > tier1/kglobalaccel/src/kglobalaccel.h PRE-CREATION > tier1/kglobalaccel/src/kglobalaccel.cpp PRE-CREATION > tier1/kglobalaccel/src/kglobalaccel_p.h PRE-CREATION > tier1/kglobalaccel/src/kglobalshortcutinfo.h PRE-CREATION > tier1/kglobalaccel/src/kglobalshortcutinfo.cpp PRE-CREATION > tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp PRE-CREATION > tier1/kglobalaccel/src/kglobalshortcutinfo_p.h PRE-CREATION > tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml PRE-CREATION > tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml PRE-CREATION > tier3/xmlgui/CMakeLists.txt 75593fb > tier3/xmlgui/autotests/CMakeLists.txt 6546ac7 > tier3/xmlgui/autotests/kglobalshortcuttest.h d8e0024 > tier3/xmlgui/autotests/kglobalshortcuttest.cpp 453920b > tier3/xmlgui/src/CMakeLists.txt 31621e2 > tier3/xmlgui/src/kactioncollection.cpp 0266069 > tier3/xmlgui/src/kglobalaccel.h 57482ad > tier3/xmlgui/src/kglobalaccel.cpp 77ce993 > tier3/xmlgui/src/kglobalaccel_p.h 50f271f > tier3/xmlgui/src/kglobalshortcutinfo.h 0920f01 > tier3/xmlgui/src/kglobalshortcutinfo.cpp d2ca948 > tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp f49bd9d > tier3/xmlgui/src/kglobalshortcutinfo_p.h dd2dd2d > tier3/xmlgui/src/kkeysequencewidget.cpp 2148ce0 > tier3/xmlgui/src/kshortcutseditor.cpp 3e917d2 > tier3/xmlgui/src/kshortcutseditoritem.cpp e7257a6 > tier3/xmlgui/src/kxmlguifactory.cpp 510d2ea > tier3/xmlgui/src/org.kde.KGlobalAccel.xml 8746551 > tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml ec21201 > tier4/kde4support/CMakeLists.txt cb73b46 > tier4/kde4support/src/CMakeLists.txt 39298b9 > tier4/khtml/CMakeLists.txt c937f38 > tier4/khtml/src/CMakeLists.txt 00243fb > > Diff: http://git.reviewboard.kde.org/r/114356/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
