On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry <k...@randomguy3.me.uk> wrote:

> Currently, we are not consistent about CMake macro naming in the
> frameworks.  KAuth, for example, has kauth_install_actions, while
> kdesignerplugin has kf5designerplugin_add_widget_files.
>
> How do we want our macros prefixed?
>
> Alex
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

I would say that we want <modulename>_<macroname>. It's what we have in
most places I'd say. I don't think it's a good idea using kf5* since it
doesn't explain where it comes from.

Aleix
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to