> On Dec. 29, 2013, 1:05 a.m., Albert Astals Cid wrote: > > src/lib/kaboutdata.cpp, line 969 > > <https://git.reviewboard.kde.org/r/114716/diff/1/?file=227634#file227634line969> > > > > Not related to your patch, but i wonder if we need a \n here too?
I don't think so. The output of "kgeography --license" gives the copyright and the license in a good format. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46342 ----------------------------------------------------------- On Dec. 29, 2013, 12:55 a.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114716/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2013, 12:55 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Without this patch, the parsing of "kgeography --author" gives: > > kgeography was written by: > Albert Astals cidaa...@kde.org > > With this patch: > > kgeography was written by: > Albert Astals Cid aa...@kde.org > > > Diffs > ----- > > src/lib/kaboutdata.cpp 3f08f25 > > Diff: https://git.reviewboard.kde.org/r/114716/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel