----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114726/#review46444 -----------------------------------------------------------
I don't really understand why this fails.... IMHO it *did* make sense for the KToolBar unittest to check which icon size the toolbars will get by default. The value of 2 on build.kde.org, for instance, should never never happen. 2 pixels for a toolbar icon is just unusable... - David Faure On Dec. 29, 2013, 6:04 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114726/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2013, 6:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > Make sure ktoolbar_unittest does not depend on global icon settings > > ktoolbar_unittest should not be testing the default settings of > KIconTheme anyway. > > > NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit > it in my absence in order to get Jenkins green again. > > > Diffs > ----- > > autotests/ktoolbar_unittest.cpp 2ee490d35b517a8121aa0aeda0d6ebb4256caad0 > > Diff: https://git.reviewboard.kde.org/r/114726/diff/ > > > Testing > ------- > > Tests pass on my local machine (but they did before as well). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
