On Mon, Dec 30, 2013 at 11:42 AM, David Faure <[email protected]> wrote: > On Monday 30 December 2013 01:26:52 Aleix Pol wrote: > > On Sun, Dec 29, 2013 at 8:10 PM, David Faure <[email protected]> wrote: > > > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: > > > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > > > > > > Hi, > > > > > > Here's a patch adding CamelCase headers to KCoreAddons > (attached). > > > > > > > > > > > > If we agree that it's the proper way of doing it, I'll proceed > to do > > > > > > it > > > > > > > > > on > > > > > > the rest of modules. > > > > > > > > > > Looks good to me. I like the fact that we can't forget to add > > > > > > forwarding > > > > > > > > headers like before - if we do, the lowercase header isn't > installed > > > > > either, so we'll notice faster :) > > > > > I mean, a single operation is needed to install a new header, > instead > > > > > > of > > > > > > > > two, one of which I always forgot. > > > > > > > > Hmm, does it really install the normal headers, too? > > > > > > > > I use it now in kate.git/ktexteditor/include/CMakelists.txt and need > > > > > > still > > > > > > > to install the normal headers manually. > > > > > > Well, Aleix's patch removes the installation of the lowercase headers, > > > doesn't > > > it? > > > > No, it creates a variable called KCoreAddons_HEADERS which is passed to > the > > install() command. ECM_GENERATE_HEADERS doesn't install anything, we > > decided to do it like that to minimize the magic factor. > > Haha, by remove I meant "removes the explicit code that installed the > lowercase headers, because it is now done semi-automatically". > > So if KCoreAddons_HEADERS contains both the lowercase and camelcase > headers, > then we fully agree :) > > -- > David Faure, [email protected], http://www.davidfaure.fr > Working on KDE, in particular KDE Frameworks 5 > > It only has the lowercase headers, uppercase headers are installed from another command: install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/KCoreAddons DESTINATION ${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Aleix
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
