----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/#review47089 -----------------------------------------------------------
I'll leave someone who knows this better (David Faure?) to say yes or no to this change. docs/README.kiosk <https://git.reviewboard.kde.org/r/114917/#comment33562> Hmm... this all looks very out-of-date. We no longer have KStandardDirs (or, at least, KConfig does not use it). src/core/kconfig.cpp <https://git.reviewboard.kde.org/r/114917/#comment33563> Missed one - kde4rc appears twice on this line. - Alex Merry On Jan. 8, 2014, 10:24 p.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114917/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 10:24 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc > > > Diffs > ----- > > docs/README.kiosk 4974ace > src/core/kconfig.cpp 4f5553d > > Diff: https://git.reviewboard.kde.org/r/114917/diff/ > > > Testing > ------- > > > Thanks, > > Siddharth Sharma > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
