----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114937/#review47176 -----------------------------------------------------------
Ship it! just two questions, feel free to commit after checking/fixing src/kconfig_compiler/kconfig_compiler.cpp <https://git.reviewboard.kde.org/r/114937/#comment33639> wouldn't <kconfig_version.h> work? seems more robust in case of moving stuff around. src/kconfig_compiler/kconfig_compiler.cpp <https://git.reviewboard.kde.org/r/114937/#comment33640> wrong indentation, or is this just reviewboard being buggy? - David Faure On Jan. 10, 2014, 4:59 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114937/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2014, 4:59 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kconfig > > > Description > ------- > > $summary > > > Diffs > ----- > > src/kconfig_compiler/kconfig_compiler.cpp df17d4c > > Diff: https://git.reviewboard.kde.org/r/114937/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
