----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/#review47230 -----------------------------------------------------------
Ship it! Just one issue, then it can go in. autotests/CMakeLists.txt <https://git.reviewboard.kde.org/r/114961/#comment33658> Use REQUIRED_QT_VERSION - Alex Merry On Jan. 11, 2014, 7:10 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114961/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2014, 7:10 a.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > ------- > > QtConcurrent and QtTest only appear to be required by autotests, so check for > them there instead of requiring them unconditionally. > > > Diffs > ----- > > CMakeLists.txt ded17c4234bb15b51d8f13979a756c7f2dff178b > autotests/CMakeLists.txt 293ab7516d7df6697cd907df847de8f8642f48ae > > Diff: https://git.reviewboard.kde.org/r/114961/diff/ > > > Testing > ------- > > Builds without without tests without the two libraries installed, and still > builds and passes tests with them installed. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
