> On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote: > > Does kde5_install_icons even exist? I can't find its definition in > > extra-cmake-modules. > > > > You say you've done no testing; surely you should at least have tried a > > fresh configure, compile and install of khtml?
Also, I would ignore khtml for now. It needs a substantial porting effort to remove its dependency on kde4support, and I don't think that's a priority for us right now. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/#review47308 ----------------------------------------------------------- On Jan. 12, 2014, 8:01 p.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114987/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 8:01 p.m.) > > > Review request for KDE Frameworks. > > > Repository: khtml > > > Description > ------- > > khtml and other components from frameworks should use kde5_install , remove > kde4 refs > > > Diffs > ----- > > tests/pics/CMakeLists.txt 3d2f8d5 > > Diff: https://git.reviewboard.kde.org/r/114987/diff/ > > > Testing > ------- > > None > > > Thanks, > > Siddharth Sharma > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
