> On Jan. 15, 2014, 11:33 a.m., Alex Merry wrote: > > CMakeLists.txt, lines 33-35 > > <https://git.reviewboard.kde.org/r/115023/diff/1/?file=234057#file234057line33> > > > > This got me wondering if we even need X11; it looks like it's not used > > directly, and it just uses HAVE_X11 in a frankly bizarre #if/#elif/#endif > > sequence in src/kkeysequencewidget.cpp (I think the #elif should just be > > #else). > > > > So I think that X11 can go altogether; that doesn't have to happen in > > this review request, though.
I noticed that too, and it definitely is strange. There are a few other similar things floating around in other frameworks too, but I am not really sure of the purpose of them. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/#review47429 ----------------------------------------------------------- On Jan. 15, 2014, 11:35 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115023/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 11:35 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > There are no source references to QtX11Extras, so remove it. > > > Diffs > ----- > > src/CMakeLists.txt 91a6ab13b62063337a3b328412071db5147a3d2c > CMakeLists.txt cea84771f4087bf5e3a39d8ed28020166473afc0 > > Diff: https://git.reviewboard.kde.org/r/115023/diff/ > > > Testing > ------- > > Builds with QtX11Extras removed. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
