----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115026/#review47497 -----------------------------------------------------------
Ship it! Lets keep the X11Embed Pandora box closed :) - Aurélien Gâteau On Jan. 15, 2014, 1:43 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115026/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 1:43 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > Remove commented out code for QX11EmbedContainer/WhatsThis > > This appears to be a hangover from the Qt 3 days, and the QXEmbed class. > It never did anything once we moved to Qt 4, and no-one seems to have > noticed. > > > Diffs > ----- > > src/khelpmenu.cpp 9ea91acba8b41e37f0c72dacb9cf4b3d32c2341f > > Diff: https://git.reviewboard.kde.org/r/115026/diff/ > > > Testing > ------- > > Configure; build; tests; install. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
