> On Jan. 16, 2014, 1:52 p.m., Alex Merry wrote: > > src/kjsembed/CMakeLists.txt, lines 38-39 > > <https://git.reviewboard.kde.org/r/115030/diff/1/?file=234081#file234081line38> > > > > These don't look like public headers; are they really needed? > > > > Pointer isn't even namespaced. And kjseglobal.h has the unnamedspaced > > RedirectIOToConsole function.
Ah, I see, they're used by binding_support.h; I don't think they should be used directly, though, and so probably shouldn't have the CamelCase versions. I'm wary about installing all these headers, and so committing to various SC and BC guarantees on them, without cleaning them up first. The un-namespaced Pointer/PointerBase class particularly concerns me. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/#review47503 ----------------------------------------------------------- On Jan. 15, 2014, 2:26 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115030/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 2:26 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > ------- > > KJsEmbed library is useless without headers installed. This patch installs > them. > > > Diffs > ----- > > CMakeLists.txt fc1731a > src/kjsembed/CMakeLists.txt b4d3f5f > > Diff: https://git.reviewboard.kde.org/r/115030/diff/ > > > Testing > ------- > > I ported the share dataengine to use it (it was using the now defunct Kross > KJS support). > > https://git.reviewboard.kde.org/r/115027/ > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
