----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/#review47533 -----------------------------------------------------------
Ship it! Seems like a good idea :) Potentially breaks the source compatibility, but then it improves the API considerably. - Aleix Pol Gonzalez On Jan. 16, 2014, 1:28 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114699/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 1:28 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kmediaplayer > > > Description > ------- > > Use enums instead of ints in method types. > > This adds to the porting effort a little (but not in many places), but gives > more type-safety. > > > Diffs > ----- > > autotests/playertest.cpp 638e86fecf7eb418c802b1f46d04e864d8e161f6 > autotests/testplayer.h 285da38fdf886ec8710e3a0d595ca20777426f86 > autotests/viewtest.cpp 337ac3eef735dab7860bb6577c72fa33d3597068 > src/kmediaplayer/player.h 57935bae537dba355b4c0cf2306dd6c993762661 > src/kmediaplayer/player.cpp c0be47666094a12abc160538798efafe1e3e1fb0 > src/kmediaplayer/view.h c3af06b51202b29f93ca0e3509ad41b8bbb91b0a > src/kmediaplayer/view.cpp 51e4c4ba5b16a4d7b90e57f78281fedb524eca54 > > Diff: https://git.reviewboard.kde.org/r/114699/diff/ > > > Testing > ------- > > Builds, tests run. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
