----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ -----------------------------------------------------------
(Updated Jan. 17, 2014, 1:03 a.m.) Review request for KDE Frameworks and Ivan Romanov. Changes ------- Move set(QCA_QT_PC_VERSION "QtCore") to else(Qt5Core_FOUND). Repository: qca Description ------- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs (updated) ----- CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing ------- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
