> On Jan. 19, 2014, 2:34 p.m., Stephen Kelly wrote: > > cmake/FindOpenEXR.cmake, line 110 > > <https://git.reviewboard.kde.org/r/115123/diff/1/?file=234689#file234689line110> > > > > I would simply add a fatal_error if cmake version is VERSION_LESS > > 2.8.12, and remove the rest of this version stuff.
Although even checking the version is arguably unnecessary, as this file is either going to be distributed with kimageformats or ECM, both of which require CMake 2.8.12. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review47698 ----------------------------------------------------------- On Jan. 19, 2014, 3:49 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115123/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2014, 3:49 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kimageformats > > > Description > ------- > > Add an imported target to FindOpenEXR.cmake > > This simplifies using the find module. > > > Diffs > ----- > > cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e > src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 > > Diff: https://git.reviewboard.kde.org/r/115123/diff/ > > > Testing > ------- > > Builds (tested when OpenEXR is found). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
