----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47897 -----------------------------------------------------------
looks good, ksjcmd is just a developer binary so nothing else needs a rename to use it a couple more changes in the man page and it's good "The most common way to run kjscmd is simply as" "The most common way to run kjscmd is simply as" - Jonathan Riddell On Jan. 19, 2014, 10:57 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115134/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2014, 10:57 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > ------- > > Patch to make kjsembed not collide with kdelibs(4) when installed to same > prefix. > Additionally, adjusted manpage to reference kjs5 instead of kjs, as that > binary has been renamed. > > > Diffs > ----- > > docs/kjscmd/CMakeLists.txt eda31bf > docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 > docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION > src/kjscmd/CMakeLists.txt a659f0f > > Diff: https://git.reviewboard.kde.org/r/115134/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel