----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/#review47955 -----------------------------------------------------------
Ship it! Still compiles fine for me (Linux, gcc). - Alex Merry On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115200/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 10:21 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kauth > > > Description > ------- > > Fix windows build > > Add a stub implementation of syslog that simply writes to stderr. > Use QThread::usleep() instead of the Unix-only usleep() > > Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1 > > > Diffs > ----- > > autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db > autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 > src/backends/dbus/DBusHelperProxy.cpp > 03f63f2edd91865cf3e636fb28df0015e7759210 > src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 > > Diff: https://git.reviewboard.kde.org/r/115200/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
