----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47959 -----------------------------------------------------------
Ship it! Looks good to me. - Aleix Pol Gonzalez On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115199/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Fix detection of shared-mime-info on Windows > > For some reason exec_program would fail, it works with execute_process > > > Diffs > ----- > > cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 > > Diff: https://git.reviewboard.kde.org/r/115199/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
