> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > Thanks for working on apidox! Sorry for the large number of comments...
Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by one tomorrow (just wanted to comment about something I clearly don't agree). > On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 103 > > <https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line103> > > > > You remove the hyphen from "auto-completion" ealier, but not here. Yes, I drop the hyphen from "auto-completion" when it works as a noun. But here (and in many other places) is working as a compound adjective. Some sources about compound adjectives and hyphens: http://writersrelief.com/blog/2008/03/hyphen-rules-dont-let-misused-hyphens-muddle-your-adjectives-or-your-writing/ http://www.grammarbook.com/punctuation/hyphens.asp Nevertheless, I may be wrong. If so, please tell me. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 ----------------------------------------------------------- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115206/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:12 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Correct spelling, grammar and style of kcompletion.h docs > > > Diffs > ----- > > src/kcompletion.h 46b63a4 > > Diff: https://git.reviewboard.kde.org/r/115206/diff/ > > > Testing > ------- > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel