----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/ -----------------------------------------------------------
(Updated Jan. 22, 2014, 9:21 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes ------- Updated diff Summary (updated) ----------------- This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_* Repository: extra-cmake-modules Description (updated) ------- This file provides the function ecm_generate_pri_file(). ECM_GENERATE_PRI_FILE() creates a .pri file for a library so that qmake-based apps can more easily use the library. It also sets ECM_MKSPECS_INSTALL_DIR as the directory to install the .pri file to. REVIEW: 115099 Make ECMSetupVersion set PROJECT_VERSION_* This makes it easier for other functions to access the project version, for instance my upcoming ECM_GENERATE_PRI_FILE() Diffs (updated) ----- modules/ECMGeneratePriFile.cmake PRE-CREATION modules/ECMSetupVersion.cmake 6c3a9959be31ee186cf173bb28585dfc52860a55 Diff: https://git.reviewboard.kde.org/r/115099/diff/ Testing ------- Adding these lines to kwidgetaddons/src/CMakeLists.txt: include(ECMGeneratePriFile) ecm_generate_pri_file(BASE_NAME KWidgetsAddons LIB_NAME KF5WidgetsAddons DEPS "widgets" FILENAME_VAR PRI_FILENAME) install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) And these to kjobwidgets: include(ECMGeneratePriFile) ecm_generate_pri_file(BASE_NAME KJobWidgets LIB_NAME KF5JobWidgets DEPS "KCoreAddons widgets" FILENAME_VAR PRI_FILENAME) install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) And I added a qmake_test subdir in kf5umbrella with qmake_test.pro saying: QT += KArchive KJobWidgets KWidgetsAddons SOURCES += main.cpp -> links to all the mentionned libs, including KCoreAddons (via KJobWidgets). This requires $QMAKEPATH set to the kf5 install prefix. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
