----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115238/#review48086 -----------------------------------------------------------
Ship it! tests/qfiledialogtest.cpp <https://git.reviewboard.kde.org/r/115238/#comment34038> no need for this debug. Thanks for improving the test, will have to look into the implementation. :) - Aleix Pol Gonzalez On Jan. 22, 2014, 10:26 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115238/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 10:26 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: frameworkintegration > > > Description > ------- > > Bug in KDEPlatformFileDialogHelper (or related code) as described below. > > The patch extends the qfiledialogtest so that the following command is > possible: > > Run ./qfiledialogtest --acceptMode save --selectFile ~/moo.png > > Expected: > - a Save File Dialog opens and the text field is filled with moo.png and the > directory switches to the given path > - The OK button is active so that the user can click it and the dialog closes > > Actual: > - a Save File Dialog opens but the text field is NOT filled and the location > does not change > - The OK button is not active > - Workaround: click on an existing file and the OK button becomes active > > > Diffs > ----- > > tests/qfiledialogtest.cpp 3ef79a2b6787bd42dfa32a6c6415111189755436 > > Diff: https://git.reviewboard.kde.org/r/115238/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
