meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> apol wrote in kio_smb.cpp:42
> Shouldn't this go in the SMBSlave class?

No this is fine, this is done the same way in trash, file, recentlyused 
io~slaves...
Follows https://github.com/shortstheory/kioslave-tutorial

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Reply via email to