dfaure added a comment.
Interesting suggestion. We're used to using names for actions everywhere, but in this specific case an enum would do indeed. When this is ported away from KActionCollection in the future, one should remember to do action->setObjectName("...") for code that actually wants strings (like KActionCollection). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns