ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed.
Two smaller issues, nothing critical INLINE COMMENTS > baloosettings.kcfgc:6 > +DefaultValueGetters=true > +GenerateProperties=true > +ParentInConstructor=true I don't think GenerateProperties is useful here. We don't use the property system in the generated class. > fileindexerconfig.cpp:119 > // write the config directly since the KCM does not have support for > the version yet > // TODO: make this class public and use it in the KCM > + m_settings->setExcludedFilters(filters); I guess this TODO comment can go with your change. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma, bruns Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
