nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The usage of KWindowSystem is not relevant on Android. This saves us a 
dependency there.
  
  Ideally we wouldn't build KPassivePopup at all there, but unfortunately it is 
public API. One could argue that such a break for non-functional API on Android 
could be okay.

TEST PLAN
  Builds on Android and Linux

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/config-knotifications.h.cmake
  src/kpassivepopup.cpp

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to