ngraham added a comment.

  Much better, thanks. Remember to mark inline comments as "Done" once you've 
addressed them.

INLINE COMMENTS

> kpropertiesdialog.cpp:1109
>  
> -        if 
> (!QStandardPaths::findExecutable(QStringLiteral("filelight")).isEmpty()) {
> +        KService::Ptr serv = 
> KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +

prefer descriptive variable names; "service" is better than "serv"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to