blaze added a comment.
In D26205#594867 <https://phabricator.kde.org/D26205#594867>, @ahmadsamir wrote: > A test case of what is broken would be appreciated, to try and fix/debug the issue. INLINE COMMENTS > ahmadsamir wrote in kwallet.cpp:180 > Any suggestions? QRegularExpression::wildcardToRegularExpression() is what > the upstream docs offer: > > > Wildcard matching > > > > There is no direct way to do wildcard matching in QRegularExpression. > > However, the wildcardToRegularExpression method is provided to translate > > glob patterns into a Perl-compatible regular expression that can be used > > for that purpose. > The transformation is targeting file path globbing, which means in particular > that path separators receive special treatment. I'm pretty sure the file path case is different from what we have here. Also > In order to match one of the special characters, place it in square brackets > (for example, "[?]") Doesn't it mean you can't just use a bare raw wildcard? So my suggestion is just to rollback to the previous solution, at least temporarily, until we don't have something better. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
