meven planned changes to this revision.
meven added a comment.

  In D26690#596551 <https://phabricator.kde.org/D26690#596551>, @dfaure wrote:
  
  > I'm quite confused by all this. Wouldn't it be enough to do 
http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ?
  >  The modified unittest passes :-)
  
  
  No because, `Default Applications` containst lists, means a same mime type in 
this group may have several
  
  In D26690#596551 <https://phabricator.kde.org/D26690#596551>, @dfaure wrote:
  
  > I'm quite confused by all this. Wouldn't it be enough to do 
http://www.davidfaure.fr/2020/kmimeassociations.cpp.diff ?
  >  The modified unittest passes :-)
  
  
  Well I think it does the trick.
  Simply by adding 25 to the basePreferrence is way more simple.
  
  I will integrate this to this patch as well as the unit test.
  Thanks

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Reply via email to