dhaumann added inline comments. INLINE COMMENTS
> kapplicationtrader.cpp:87 > + KService::List::iterator it = lst.begin(); > + while (it != lst.end()) { > + KService::Ptr serv = *it; I would prefer the std::erase(std::remove_if(...), ...end()); idiom here. Assuming the list is a vector this will be much faster, or do you have to preserve the order? I fear I know the answer :-) > kapplicationtrader.h:48 > +{ > + using FilterFunc = std::function<bool(const KService::Ptr &)>; > + Please document this typedef so that FilterFunc will be clickable in the generated API documentation. > kapplicationtrader.h:80 > + * > + * This a convenience methode for queryByMimeType(mimeType).at(0), with > a check for empty. > + * method without training e. > kapplicationtrader.h:90 > + /** > + * Returns true if @p pattern matches a subsequence of the string @p > text. > + * For instance the pattern "libremath" matches the text "LibreOffice > Math", assuming Maybe mention when this function is useful? For me it looks like a private helper function. Why is it public? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns