leinir updated this revision to Diff 74227. leinir added a comment.
- Don't suggest making reviews if you're writing a reply comment - Don't pull up a comments model until we actually need it REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26794?vs=74225&id=74227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26794 AFFECTED FILES src/attica/atticaprovider.cpp src/attica/atticaprovider_p.h src/core/commentsmodel.cpp src/core/commentsmodel.h src/core/engine.cpp src/core/engine.h src/core/provider.h src/qtquick/qml/EntryDetails.qml src/qtquick/qml/private/EntryCommentDelegate.qml src/qtquick/qml/private/EntryCommentsPage.qml src/qtquick/qml/private/NewCommentSheet.qml src/qtquick/qml/private/Rating.qml src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml src/qtquick/quickengine.cpp src/qtquick/quickengine.h src/qtquick/quickitemsmodel.cpp src/qtquick/quickitemsmodel.h src/ui/entrydetailsdialog.cpp src/ui/itemsviewdelegate.cpp To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
