dfaure accepted this revision. dfaure added a comment.
Nice work! Thanks for the unittest extension. INLINE COMMENTS > jobtest.cpp:1731 > + > + qDebug() << sourceFile << renamedFile; > + QVERIFY2(job->exec(), qPrintable(job->errorString())); Please clean up before committing > jobtest.cpp:1740 > + > + QFile(sourceFile).remove(); > + QDir(dest).removeRecursively(); QVERIFY(...) > jobtest.cpp:1741 > + QFile(sourceFile).remove(); > + QDir(dest).removeRecursively(); > +} QVERIFY(...) REPOSITORY R241 KIO BRANCH arcpatch-D26878 REVISION DETAIL https://phabricator.kde.org/D26878 To: meven, #frameworks, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
