apol added inline comments. INLINE COMMENTS
> kconfigloader.cpp:125 > for (int i = 0; i < numAttrs; ++i) { > - QString name = attrs.localName(i).toLower(); > + const QString name = attrs.at(i).name().toString().toLower(); > if (name == QLatin1String("name")) { You can use QStringRef::compare() in this if sequence over here too. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns