> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote: > > src/lib/kaboutdata.cpp, line 941 > > <https://git.reviewboard.kde.org/r/115207/diff/1/?file=235099#file235099line941> > > > > Not really my type of thing. It's acting on an object behind our back > > without knowing... what happens to code where setApplication* was called > > before? Information would be lost and it's not obvious to the user. Looks > > dangerous to me. > > > > If we want to factorize the qApp call, and I see the need for that > > indeed, then that block should be provided by a separate method > > (setupApplication(QCoreApplication *)?).
I agree, I only did it this way to avoid the required set up. An alternative would be to make KAboutData to pass the information to Q*Application when it's initialized (and if it's an application KAboutData...). - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review48347 ----------------------------------------------------------- On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115207/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:36 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Let the KAboutData set information to QApplication. This way we don't have to > duplicate information by passing it to the KAboutData _and_ the QApplication. > > > Diffs > ----- > > src/lib/kaboutdata.h 2222c9e > src/lib/kaboutdata.cpp f24006b > > Diff: https://git.reviewboard.kde.org/r/115207/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
