ervin added inline comments. INLINE COMMENTS
> KConfigHeaderGenerator.cpp:267 > + > + for (const auto signal : qAsConst(parseResult.signalList)) { > + stream() << whitespace() << " " << signalEnumName(signal.name) << " > = 0x" << hexValue << val << ",\n"; You use "const Signal &" a few lines below, makes me wonder shouldn't they both be "const auto &" then? at least for consistency? REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns