----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/#review48490 -----------------------------------------------------------
Ship it! I tried it here, doesn't seem to break. Also it's really ugly to have -lc so +1 from me. - Aleix Pol Gonzalez On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115362/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 4:41 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Do not explicitly link against libc > > This is entirely unnecessary. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > 3419cb1266c63f9cdec0501ae340aabe7c0b6096 > > Diff: https://git.reviewboard.kde.org/r/115362/diff/ > > > Testing > ------- > > KCoreAddons and KDE4Support still configure and compile (GCC 4.8.2 20131219; > Linux with glibc 2.18). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
