ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:12
>
> +FILE(GLOB translucent_dialogs translucent/dialogs/*.svg)
> +plasma_install_desktoptheme_svgs(default SUBPATH translucent/dialogs FILES
> ${translucent_dialogs})
Using GLOB in CMake is considered a code smell; just list the individual files
explicitly.
Also this doesn't work; the files don't get installed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27122
To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin,
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk,
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde,
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef,
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
