bruns added inline comments.
INLINE COMMENTS
> CMakeLists.txt:3
> + filesystem_entry.cpp
> + filesystem_entry.h
> fstabmanager.cpp
remove
> filesystem_entry.cpp:59
> +{
> + if (m_type == QLatin1Literal("fuse.encfs")) {
> + return m_device + QLatin1Char('@') + m_mountPath;
store this in the entry, otherwise you pay the cost on every access
> filesystem_entry.h:34
> +/*
> + * Class that represents a filesystem. The filesystem is either mounted by
> the system or can be mounted by the system.
> + * The information in the class is modelled around the fstab/mtab type files.
wrap long lines, also below.
> filesystem_entry.h:48
> + */
> + QString mountPath() const;
> + /*
Whats wrong with mountPoint? Its used everywhere else here, and is a well known
term.
> fstabhandling.cpp:168
> const QString device = _k_deviceNameForMountpoint(fsname,
> fstype, mountpoint);
> QStringList options =
> QFile::decodeName(fe->mnt_opts).split(QLatin1Char(','));
>
should be const now
> fstabhandling.cpp:209
> const QString mountpoint = items.at(1);
>
> + globalFstabCache->localData().m_fstabCache.insert(device,
> FilesystemEntry(device, mountpoint, items.at(2), QStringList()));
add temporary for fstype
> fstabhandling.cpp:259
> + QStringList mountpoints;
> + for (const auto& dev : globalFstabCache->localData().m_fstabCache) {
> + if (!dev.mountPath().isEmpty()) {
detaches m_fstabCache, also below.
> fstabhandling.cpp:275
> {
> _k_updateFstabMountPointsCache();
>
missing `_k_updateMtabMountPointsCache();`
> fstabhandling.cpp:290
> {
> _k_updateFstabMountPointsCache();
>
dito
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D27152
To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
