apol added a comment.
LGTM otherwise
INLINE COMMENTS
> colorscope.cpp:57
> + connect(parentItem, &QQuickItem::windowChanged,
> this, [this]() {
> findParentScope();
let's make this a proper method? it's used twice here and a normal method
should be quicker to use and easier on the reader.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27200
To: mart, bshah, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
