ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
LGTM and fixes all the bugs! Thanks. If it lands quickly, I wonder if it would be worth it to try and squeeze this into Frameworks 5.67 so all the people using this dialog in Plasma 5.18 see the polished-up version from the start. REPOSITORY R304 KNewStuff BRANCH fix-dialog-background-and-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D27204 To: leinir, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns