----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/#review48510 -----------------------------------------------------------
kde-modules/KDECompilerSettings.cmake <https://git.reviewboard.kde.org/r/115372/#comment34293> It'd be nice to add an else() message(WARNING "Unsupported compiler ${CMAKE_CXX_COMPILER_ID}") kde-modules/KDECompilerSettings.cmake <https://git.reviewboard.kde.org/r/115372/#comment34294> elseif() would fit better here. kde-modules/KDECompilerSettings.cmake <https://git.reviewboard.kde.org/r/115372/#comment34295> else: warn about unsupported compiler kde-modules/KDECompilerSettings.cmake <https://git.reviewboard.kde.org/r/115372/#comment34297> Unrelated, but for MSVC there are no additional flags. ICL supports the same features as MSVC, there is "/Qstd=c++11" but only for the features ICL supports but MSVC doesn't. So, this FIXME can be removed. kde-modules/KDECompilerSettings.cmake <https://git.reviewboard.kde.org/r/115372/#comment34296> Unrelated, but I've check the MSDN examples for these warnings and icl raises none of them for these, so these can be done for MSVC only. - Andrius da Costa Ribas On Jan. 28, 2014, 11:22 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115372/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 11:22 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Improve the compiler version checks > > - Only warn if the compiler is not recent enough (it may still work...) > - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt > - Add checks for Windows (both MSVC and MinGW) that match Qt > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > a4683b04459a2dca1bc5daab0c69c06acbf33ce0 > > Diff: https://git.reviewboard.kde.org/r/115372/diff/ > > > Testing > ------- > > Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
