> On Jan. 29, 2014, 2:29 p.m., Alex Merry wrote: > > kde-modules/KDECompilerSettings.cmake, lines 204-206 > > <https://git.reviewboard.kde.org/r/115376/diff/1/?file=240951#file240951line204> > > > > I would have gone for > > if (NOT flags) > > # CMake can give NOTFOUND as a result > > set(flags) > > endif() > > which may be more resilient to possible changes in the implementation > > of get_source_file_property, but I'm not that fussed either way.
Oh right NOTFOUND is considered FALSE. CMake is a weird language :/. Going to do it this way, it's more future proof indeed. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115376/#review48533 ----------------------------------------------------------- On Jan. 29, 2014, 11:17 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115376/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 11:17 a.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file} > COMPILEFLAGS) set flags to "NOTFOUND". Leading to interesting build failures > in kde-runtime when we then set flags to "NOTFOUND -fexceptions", see > http://build.kde.org/job/kde-runtime_frameworks_qt5/58/ > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake 6b7ab4e > > Diff: https://git.reviewboard.kde.org/r/115376/diff/ > > > Testing > ------- > > Built kde-runtime successfully. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
