----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ -----------------------------------------------------------
(Updated Jan. 29, 2014, 4:30 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Changes ------- Added an extra commit that replaces compiler id checks against MSVC with checking the MSVC variable. Repository: extra-cmake-modules Description (updated) ------- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs (updated) ----- kde-modules/KDECompilerSettings.cmake 62ba4a0ab2cd2615fb54b3f938784b753bcff132 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing ------- Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
