davidedmundson added a comment.

  Good start. The direction makes sense.
  
  display.cpp and registry.cpp need updating to the new version number. 
Otherwise we won't be able to use this new method.
  
  It'd be great if you could update the unit test too.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:599
> +        }
> +        org_kde_plasma_window_send_application_menu_changed(resource, 
> qUtf8Printable(service), qUtf8Printable(object));
> +    }

We're mixing up our local 8bit and utf8 on different sides of this.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Reply via email to