meven added inline comments. INLINE COMMENTS
> kconfigdialogmanager_p.h:60 > + QHash<QString, QWidget *> buddyWidget; > + QHash<QString, SettingStatusIndicator *> indicatorWidget; > + QSet<QWidget *> allExclusiveGroupBoxes; I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets > settingsstatusindicator_p.h:41 > + bool isDefaulted() const; > + void setDefaulted(bool defaulted); > + Make setChanged and setDefaulted as slots to ease the reuse of this class outside of KConfigDialogManager REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
